wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.68k stars 1.11k forks source link

T18442: Reevaluate site title font when button state changes #23640

Closed christianbilodeau closed 1 week ago

christianbilodeau commented 1 week ago

Evaluate which font to display every time the titleTextAttributesTransformer is executed. This way, if the font scale is changed in accessibility settings, the site title font will be updated with the right size upon reentering the app.

Fixes #18442

Before:

After:

Regression Notes

  1. Potential unintended areas of impact

    • Appearance on iPhone & iPad
    • Appearance in portrait or landscape
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

Screenshot 2024-09-30 at 16 18 23
  1. What automated tests I added (or what prevented me from doing so) Didn't find similar tests in codebase + impractical to test dynamic text size

PR submission checklist:

Testing checklist:

wpmobilebot commented 1 week ago
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23640-d7c3f48
Version25.4
Bundle IDorg.wordpress.alpha
Commitd7c3f48343ccc3f9bb549625ccf6ef1a983540bc
App Center BuildWPiOS - One-Offs #10767
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
wpmobilebot commented 1 week ago
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23640-d7c3f48
Version25.4
Bundle IDcom.jetpack.alpha
Commitd7c3f48343ccc3f9bb549625ccf6ef1a983540bc
App Center Buildjetpack-installable-builds #9809
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.