Find the right WP.com account for Jetpack connected sites

crazytonyli commented 1 week ago

Issue

Jetpack connected sites can't be added to the app if the app is signed in using a different WP.com account.

Here are steps (taken from a internal discussion p1727463794673359-slack-C06S1QS55K9) to reproduce the bug:

Create a site, connect Jetpack to WPCOM Account A.
Log into the Jetpack mobile app with WPCOM Account B.
Add the targeted self-hosted site.
:boom: All site requests are sent to public-api.wordpress.com and fail to locate the site.

Changes

The current app WP.com account is incorrectly assigned to the self-hosted site. The fix is simply lookup the right account for the added site.

~However, the account look up will always results in nil though, because we only have one account in the app.~ Users can log in to another account by going to the Stats screen in the new self-hosted site. This flow is broken at the moment though. I'm looking into the issue, but any change would result in a separate PR.

Regression Notes

Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)

PR submission checklist:

[ ] I have completed the Regression Notes.
[ ] I have considered adding unit tests for my changes.
[ ] I have considered adding accessibility improvements for my changes.
[ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

[ ] WordPress.com sites and self-hosted Jetpack sites.
[ ] Portrait and landscape orientations.
[ ] Light and dark modes.
[ ] Fonts: Larger, smaller and bold text.
[ ] High contrast.
[ ] VoiceOver.
[ ] Languages with large words or with letters/accents not frequently used in English.
[ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
[ ] iPhone and iPad.
[ ] Multi-tasking: Split view and Slide over. (iPad)

wpmobilebot commented 1 week ago

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23644-50545de
	Version	25.4
	Bundle ID	com.jetpack.alpha
	Commit	50545de3c429310806b256d4b4aafadfee8ce0ec
	App Center Build	jetpack-installable-builds #9815

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot commented 1 week ago

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23644-50545de
	Version	25.4
	Bundle ID	org.wordpress.alpha
	Commit	50545de3c429310806b256d4b4aafadfee8ce0ec
	App Center Build	WPiOS - One-Offs #10773

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

kean commented 1 week ago

However, the account look up will always results in nil though, because we only have one account in the app.

The app doesn't have multiple account support. I'm not entirely sure what's the optimal way to proceed, but the first option that comes to mind is to throw an error in case someone adds a site not connected to their current wp.com account. It's best to provide no support for multiple accounts than one that's only partially works. It might open a whole can of worms.

When you connect a self-hosted sites to stats and have a wp.com account, you should be able to connect only the current default account.

crazytonyli commented 1 week ago

When you connect a self-hosted sites to stats and have a wp.com account, you should be able to connect only the current default account.

The app currently has trouble with signing in with another account. But I believe having multiple accounts (even though they are not visible on UI) is something app used to support. It's just broken at some point. See my fix in https://github.com/wordpress-mobile/WordPress-iOS/pull/23654

wordpress-mobile / WordPress-iOS