wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.68k stars 1.11k forks source link

Remove localizable strings and edit only NSLocalizedString(). #23645

Closed mrpolanco closed 6 days ago

mrpolanco commented 1 week ago

Fixes #23634

Added clarity to the verification code view that the code is for WordPress.com:

Before-After - iPhone 16 Pro - 2024-09-27 at 14 58 20-side

Regression Notes

  1. Potential unintended areas of impact
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

Testing checklist:

kean commented 1 week ago

Thanks for the update. I'll get it merged it soon.

mrpolanco commented 1 week ago

Thank you for the assistance and feedback, @kean! Hoping that the next updates are a lot smoother 🤞

wpmobilebot commented 1 week ago
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23645-dfb4247
Version25.4
Bundle IDorg.wordpress.alpha
Commitdfb4247eeefc2237a6cdc19e7d9ff4d2b8c27cd2
App Center BuildWPiOS - One-Offs #10788
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
wpmobilebot commented 1 week ago
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23645-dfb4247
Version25.4
Bundle IDcom.jetpack.alpha
Commitdfb4247eeefc2237a6cdc19e7d9ff4d2b8c27cd2
App Center Buildjetpack-installable-builds #9830
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.