wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.68k stars 1.11k forks source link

Fix issue in signing into another WP.com account #23654

Open crazytonyli opened 1 week ago

crazytonyli commented 1 week ago

This PR is built on top of https://github.com/wordpress-mobile/WordPress-iOS/pull/23644.

This PR fixes an issue with having multiple WP.com accounts in the app. Here are steps to reproduce the issue.

  1. Create a self-hosted site and connect it to WP.com account A.
  2. Open Jetpack app and sign in using WP.com account B.
  3. Add the self-hosted site in step 1.
  4. Tap "Stats" of the self-hosted site. You'll see a "Log in" button here.
  5. Tap the Log in button to sign in with WP.com account A.

Expected behaviour: the app displays Stats content after successful login.

Actual behaviour: the app is kind of messed up, because it incorrectly saves the second WP.com account as the default account.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

Testing checklist:

wpmobilebot commented 1 week ago
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23654-c3e32dd
Version25.4
Bundle IDcom.jetpack.alpha
Commitc3e32dd830c996698cecf8052cae029133eb31e9
App Center Buildjetpack-installable-builds #9824
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
wpmobilebot commented 1 week ago
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23654-c3e32dd
Version25.4
Bundle IDorg.wordpress.alpha
Commitc3e32dd830c996698cecf8052cae029133eb31e9
App Center BuildWPiOS - One-Offs #10782
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.