wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.68k stars 1.11k forks source link

Fix crash in TipKit #23664

Closed kean closed 2 days ago

kean commented 2 days ago

Crash: https://a8c.sentry.io/issues/5872820860/?environment=appStore&project=5716771&query=release%3Acom.automattic.jetpack%4025.3%2B25.3.0.1&referrer=release-issue-stream

There seems to be an issue with the way parameters for tips are designed/implementd and how they interact with the #available check. I'm removing this code just to be safe.

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

Testing checklist:

dangermattic commented 2 days ago
1 Warning
:warning: This PR is assigned to the milestone 25.4 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

wpmobilebot commented 2 days ago
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23664-df97799
Version25.4
Bundle IDcom.jetpack.alpha
Commitdf97799011d4bd6aa8925823d90f5ff210065fdd
App Center Buildjetpack-installable-builds #9837
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
wpmobilebot commented 2 days ago
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23664-df97799
Version25.4
Bundle IDorg.wordpress.alpha
Commitdf97799011d4bd6aa8925823d90f5ff210065fdd
App Center BuildWPiOS - One-Offs #10795
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.