Site Settings: Fix issue with saving site settings

kean commented 4 days ago

Fixes https://github.com/wordpress-mobile/WordPress-iOS/issues/23787. The app will now use the existing method didChangeSetting for tracking changes in DiscussionSettingsViewController as a trigger for save. I also made a couple of other changes:

Fix an issue where if you change settings fairly quickly, the app will send parallel requests
Add error handling (was completely missing!)
Add a spinner to the navigation bar to indicate when the save is happening (on iPad shown in the left corner)
Remove “refresh settings” as it happens on the root screen already. There is no point to do it again here and it might mess with some of the local changes.

Note: ignore the first commit https://github.com/wordpress-mobile/WordPress-iOS/pull/23831/commits/b24ddf8d500b7355ff71e76298d9ed9540f621e2 as it simply fixes the formatting.

https://github.com/user-attachments/assets/8148c2f5-5ea1-4aef-939a-c66590085375

To test:

Regression Notes

Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)

PR submission checklist:

[ ] I have completed the Regression Notes.
[ ] I have considered adding unit tests for my changes.
[ ] I have considered adding accessibility improvements for my changes.
[ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

[ ] WordPress.com sites and self-hosted Jetpack sites.
[ ] Portrait and landscape orientations.
[ ] Light and dark modes.
[ ] Fonts: Larger, smaller and bold text.
[ ] High contrast.
[ ] VoiceOver.
[ ] Languages with large words or with letters/accents not frequently used in English.
[ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
[ ] iPhone and iPad.
[ ] Multi-tasking: Split view and Slide over. (iPad)

dangermattic commented 4 days ago

	1 Warning
:warning:	This PR is assigned to the milestone 25.5. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

wpmobilebot commented 4 days ago

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23831-6e6094c
	Version	25.4.2
	Bundle ID	org.wordpress.alpha
	Commit	6e6094cf000536b85e559af29dcdadc4c47a7d17
	App Center Build	WPiOS - One-Offs #11082

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot commented 4 days ago

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23831-6e6094c
	Version	25.4.2
	Bundle ID	com.jetpack.alpha
	Commit	6e6094cf000536b85e559af29dcdadc4c47a7d17
	App Center Build	jetpack-installable-builds #10123

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wordpress-mobile / WordPress-iOS

Site Settings: Fix issue with saving site settings #23831

Regression Notes