Move Application Passwords entry to user details

crazytonyli commented 1 week ago

This is an alternative to https://github.com/wordpress-mobile/WordPress-iOS/pull/23819.

In #23819, application passwords are displayed in the user details view, like wp-admin. But I think @kean 's suggestion in https://github.com/wordpress-mobile/WordPress-iOS/pull/23819#discussion_r1846659725 makes more sense.

Regression Notes

Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)

PR submission checklist:

[ ] I have completed the Regression Notes.
[ ] I have considered adding unit tests for my changes.
[ ] I have considered adding accessibility improvements for my changes.
[ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

[ ] WordPress.com sites and self-hosted Jetpack sites.
[ ] Portrait and landscape orientations.
[ ] Light and dark modes.
[ ] Fonts: Larger, smaller and bold text.
[ ] High contrast.
[ ] VoiceOver.
[ ] Languages with large words or with letters/accents not frequently used in English.
[ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
[ ] iPhone and iPad.
[ ] Multi-tasking: Split view and Slide over. (iPad)

dangermattic commented 1 week ago

	1 Warning
:warning:	This PR is assigned to the milestone 25.6. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

wpmobilebot commented 1 week ago

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23834-10c98ee
	Version	25.4.2
	Bundle ID	org.wordpress.alpha
	Commit	10c98ee20730cd3c8a93d5d3578b8303f41999c1
	App Center Build	WPiOS - One-Offs #11131

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot commented 1 week ago

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23834-10c98ee
	Version	25.4.2
	Bundle ID	com.jetpack.alpha
	Commit	10c98ee20730cd3c8a93d5d3578b8303f41999c1
	App Center Build	jetpack-installable-builds #10171

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

jkmassel commented 2 days ago

If the site doesn't have a valid Application Token, every request just fails – there's no feedback or alerting.

We should address that before this ships.

I also noticed that User Management is still behind a feature flag – with this change, we should tie user management and application passwords together, because otherwise it's impossible to get at your application password list.

jkmassel commented 2 days ago

Should admin users be able to see others' application passwords?

crazytonyli commented 2 days ago

If the site doesn't have a valid Application Token, every request just fails – there's no feedback or alerting.

This is an existing issue with account passwords too. There is no re-authentication flow, when account password is changed.

Should admin users be able to see others' application passwords?

Not sure about if they should, but they can 😄 . On web, admin users can view, add, and revoke others application passwords.

wordpress-mobile / WordPress-iOS

Move Application Passwords entry to user details #23834

Regression Notes