wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.7k stars 1.12k forks source link

Extract delete user confirmation sheet into its own view #23835

Open crazytonyli opened 4 days ago

crazytonyli commented 4 days ago

[!Note] This PR is built on top of https://github.com/wordpress-mobile/WordPress-iOS/pull/23834.

Nothing too interesting really. Just moving a ViewBuilder function to a View type.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

Testing checklist:

dangermattic commented 4 days ago
1 Warning
:warning: View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by :no_entry_sign: Danger

wpmobilebot commented 4 days ago
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23835-c95b8fa
Version25.4.2
Bundle IDorg.wordpress.alpha
Commitc95b8fa0594c45ec5f2eecca60da1e273a5688ff
App Center BuildWPiOS - One-Offs #11088
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
wpmobilebot commented 4 days ago
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23835-c95b8fa
Version25.4.2
Bundle IDcom.jetpack.alpha
Commitc95b8fa0594c45ec5f2eecca60da1e273a5688ff
App Center Buildjetpack-installable-builds #10129
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
kean commented 4 days ago

The current form look a bit off.

Screenshot 2024-11-20 at 8 55 21 AM

Id suggest the following changes (not necessarily in the scope of this PR):

Screenshot 2024-11-20 at 8 37 07 AM
        Form {
            Section {
                NavigationLink {
                    EmptyView()
                } label: {
                    HStack {
                        Text("Selected User")
                        Spacer()
                        Text("username2")
                            .foregroundStyle(.secondary)
                    }

                }
            } header: {
                Text("Select the user to attribute the content of the site to")
                    .font(.body)
                    .textCase(nil)
                    .foregroundStyle(.primary)
                    .padding(.bottom, 8)
            }
        }