Open crazytonyli opened 4 days ago
2 Warnings | |
---|---|
:warning: | Modules/Package.swift was changed without updating its corresponding Package.resolved . Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve ). |
:warning: | This PR is assigned to the milestone 25.6. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished. |
Generated by :no_entry_sign: Danger
App Name | WordPress Alpha | |
Configuration | Release-Alpha | |
Build Number | pr23838-c38b7e5 | |
Version | 25.4.2 | |
Bundle ID | org.wordpress.alpha | |
Commit | c38b7e557584d8f005a88ee2935416c30d3238b8 | |
App Center Build | WPiOS - One-Offs #11094 |
App Name | Jetpack Alpha | |
Configuration | Release-Alpha | |
Build Number | pr23838-c38b7e5 | |
Version | 25.4.2 | |
Bundle ID | com.jetpack.alpha | |
Commit | c38b7e557584d8f005a88ee2935416c30d3238b8 | |
App Center Build | jetpack-installable-builds #10134 |
Apple recommends to work in waves: enable the flags, fix some issues, disable the flags. Continue until there are no more warnings/errors and the flags can be enabled permanently.
@kean I thought enabling the concurrency checks (with errors) earlier would be nice, especially considering we have added @unchecked Sendable
everywhere (in https://github.com/wordpress-mobile/WordPress-iOS/pull/23527) to ignore the concurrency check warnings.
This PR will introduce about 100+ more warnings. I'll "address" (probably just
@unchecked Sendable
) them in follow up PRs.As the warnings gone, I'll remove the compiler flags, which means compiler will report errors if new code violates concurrency rules.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: