wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.7k stars 1.12k forks source link

Make Xcode report concurrency warnings on the Modules package #23838

Open crazytonyli opened 4 days ago

crazytonyli commented 4 days ago

This PR will introduce about 100+ more warnings. I'll "address" (probably just @unchecked Sendable) them in follow up PRs.

As the warnings gone, I'll remove the compiler flags, which means compiler will report errors if new code violates concurrency rules.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

Testing checklist:

dangermattic commented 4 days ago
2 Warnings
:warning: Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
:warning: This PR is assigned to the milestone 25.6. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

wpmobilebot commented 4 days ago
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23838-c38b7e5
Version25.4.2
Bundle IDorg.wordpress.alpha
Commitc38b7e557584d8f005a88ee2935416c30d3238b8
App Center BuildWPiOS - One-Offs #11094
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
wpmobilebot commented 4 days ago
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23838-c38b7e5
Version25.4.2
Bundle IDcom.jetpack.alpha
Commitc38b7e557584d8f005a88ee2935416c30d3238b8
App Center Buildjetpack-installable-builds #10134
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
kean commented 4 days ago

Apple recommends to work in waves: enable the flags, fix some issues, disable the flags. Continue until there are no more warnings/errors and the flags can be enabled permanently.

crazytonyli commented 2 days ago

@kean I thought enabling the concurrency checks (with errors) earlier would be nice, especially considering we have added @unchecked Sendable everywhere (in https://github.com/wordpress-mobile/WordPress-iOS/pull/23527) to ignore the concurrency check warnings.