Closed kean closed 2 days ago
App Name | WordPress Alpha | |
Configuration | Release-Alpha | |
Build Number | pr23843-13a370e | |
Version | 25.4.2 | |
Bundle ID | org.wordpress.alpha | |
Commit | 13a370e4c5697a65ad5cd23da41c3d46f73d083c | |
App Center Build | WPiOS - One-Offs #11098 |
App Name | Jetpack Alpha | |
Configuration | Release-Alpha | |
Build Number | pr23843-13a370e | |
Version | 25.4.2 | |
Bundle ID | com.jetpack.alpha | |
Commit | 13a370e4c5697a65ad5cd23da41c3d46f73d083c | |
App Center Build | jetpack-installable-builds #10138 |
1 Warning | |
---|---|
:warning: | View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity. |
Generated by :no_entry_sign: Danger
A couple of small changes getting us closer to removing
AlamofireImage
.LoadingIndicator
parameter fromImageLoader
(plan is to integrateAsyncImageView
)ImageLoader
ImageViewController
(this will be needed to replace af.setImage)error
toImageViewController.failure
stateImageView
toAsyncImageView
(purpose more clear and rhymes with `AsyncImage)I also plan to move
ImageDownloader
to a new SwiftPM package soon. I'm thinking about naming itWordPressMedia
and adding other media-related stuff there too. Thoughts?To test: n/a for now
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: