wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.7k stars 1.12k forks source link

Prerequisites for removing AlamofireImage #23843

Closed kean closed 2 days ago

kean commented 3 days ago

A couple of small changes getting us closer to removing AlamofireImage.

I also plan to move ImageDownloader to a new SwiftPM package soon. I'm thinking about naming it WordPressMedia and adding other media-related stuff there too. Thoughts?

To test: n/a for now

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

Testing checklist:

wpmobilebot commented 3 days ago
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23843-13a370e
Version25.4.2
Bundle IDorg.wordpress.alpha
Commit13a370e4c5697a65ad5cd23da41c3d46f73d083c
App Center BuildWPiOS - One-Offs #11098
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
wpmobilebot commented 3 days ago
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23843-13a370e
Version25.4.2
Bundle IDcom.jetpack.alpha
Commit13a370e4c5697a65ad5cd23da41c3d46f73d083c
App Center Buildjetpack-installable-builds #10138
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
dangermattic commented 3 days ago
1 Warning
:warning: View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by :no_entry_sign: Danger