wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.7k stars 1.12k forks source link

Reader: Fix load-more spinner not visible in dark mode #23847

Closed kean closed 5 days ago

kean commented 6 days ago

I replaced the old version with a new PagingFooterView. The previous version seemingly used to hardcode a particular shared of gray so it wasn't visible, but I didn't confirm that.

Screenshot 2024-11-21 at 9 39 08 AM

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

Testing checklist:

dangermattic commented 6 days ago
1 Warning
:warning: This PR is assigned to the milestone 25.5. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

wpmobilebot commented 6 days ago
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23847-39ca1b8
Version25.4.2
Bundle IDorg.wordpress.alpha
Commit39ca1b84fa763ef8e9f9442fd29c7b442d164088
App Center BuildWPiOS - One-Offs #11105
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
wpmobilebot commented 6 days ago
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23847-39ca1b8
Version25.4.2
Bundle IDcom.jetpack.alpha
Commit39ca1b84fa763ef8e9f9442fd29c7b442d164088
App Center Buildjetpack-installable-builds #10145
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.