wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.7k stars 1.12k forks source link

Reader: Enhance loading experience in post details #23852

Closed kean closed 2 days ago

kean commented 2 days ago

The current implementation is not great because:

  1. We already have everything we need to display the post we just need to wait for the web view to finish
    1. The skeleton view is a bit wacky with weird shapes and spacing

In the new version, the app displays everything it has immediately and just shows the spinner covering the web view.

https://github.com/user-attachments/assets/f791255b-edba-4f50-94bf-1a7ab1f4698c

https://github.com/user-attachments/assets/43f6d0d9-f1bc-47ab-981f-92526685ff39

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

Testing checklist:

wpmobilebot commented 2 days ago
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23852-16dbb81
Version25.4.2
Bundle IDcom.jetpack.alpha
Commit16dbb81a5f9ccbf19dd9c63d10ccc16f51de4e57
App Center Buildjetpack-installable-builds #10151
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
wpmobilebot commented 2 days ago
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23852-16dbb81
Version25.4.2
Bundle IDorg.wordpress.alpha
Commit16dbb81a5f9ccbf19dd9c63d10ccc16f51de4e57
App Center BuildWPiOS - One-Offs #11111
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
dangermattic commented 2 days ago
1 Warning
:warning: This PR is assigned to the milestone 25.5. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger