search

wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.69k stars 1.12k forks source link

Reader: Audit and restyle status/busy states for consistency. #5621

Open aerych opened 8 years ago

aerych commented 8 years ago

In some places the following / unfollowing actions display a status HUD, but in some places they do not. The HUD blocks the UI, which isn't great, but showing the progress of a follow/unfollow action has some value.

Let's review how we're informing the user of progress and settle on a consistent approach. @mattmiklic, @jancavan, this would really benefit from your input.

jancavan commented 8 years ago

@aerych Not sure where this is happening. Can you please point me to the right direction?

aerych commented 8 years ago

Sure!

Tag/Site Headers - Tapping to follow/unfollow here is optimistically updated. No waiting.

Manage Site Screen - Enter the URL of a site to follow. It takes a few seconds for the network calls to complete, meanwhile there is no status feedback in the UI.

Post Detail - Tap the menu icon and follow or unfollow the site. You'll see a spinner appear and eventually get a confirmation that the site was followed/unfollowed. Here's a video: https://cloudup.com/cUPcma-intd

jancavan commented 8 years ago

Thanks for the detailed info!

Is there a reason why in site headers there isn't a delay while in full-posts there is?

Also, as mentioned in this issue: https://github.com/wordpress-mobile/WordPress-iOS/issues/5763, I don't think we should be hiding the Follow button in an ellipsis. This may be a silly question, but if Follow weren't hidden, will that somehow eliminate the delay?

aerych commented 8 years ago

Is there a reason why in site headers there isn't a delay while in full-posts there is?

I'm not sure exactly why we're doing things differently there. The site header optimistically reflects the follow or unfollow action before the actual API call is made. We could probably do the same following/unfollowing from the post detail.