wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.69k stars 1.12k forks source link

Media toolbar moves up after close without selection #8413

Closed SergioEstevao closed 6 years ago

SergioEstevao commented 6 years ago

Expected behavior

On an iPhone X the Media toolbar should always be on top of the media items

Actual behavior

Media toolbar moves up and leaves a gap between the toolbar and the media items.

screen shot 2018-01-09 at 13 01 56

Steps to reproduce the behavior

Tested on iPhone X, iOS 11, WPiOS 9.1
SergioEstevao commented 6 years ago

@bummytime and/or @frosty could this be related to our code for detection of keyboard screen size?

bummytime commented 6 years ago

@SergioEstevao it's possible. Let me take a look.

bummytime commented 6 years ago

@SergioEstevao Still investigating this, but in the sim not using the picker, I was able to repro the gap by initially loading a draft post in Aztec:

simulator screen shot - iphone x - 2018-01-09 at 08 31 36

(The inputAccessoryView snaps back in place when you select the main content area.)

I also noticed in the sim that dismissing/activating the soft keyboard a few times can also cause the gap to appear:

simulator screen shot - iphone x - 2018-01-09 at 08 32 44

bummytime commented 6 years ago

Also, looks like this issue is only affecting the iPhone X.