search

wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.66k stars 1.11k forks source link

Sign up: Username changer loading shouldn't be a modal #8761

Open folletto opened 6 years ago

folletto commented 6 years ago

screen shot 2018-02-28 at 14 59 44

When the username list loads, it shouldn't use a modal view with the loader, as the above.

The change could be done at two levels.

Level 1

We don't show anything while loading: the list is pre-populated with the existing username (thus, it has at least one item, selected) while loads the first time, and for loads while searching the list simply updates once the API is returned.

Level 2

If we want explicit indicators, here's a design for it:

mobile-username-picker-loading-states-i5

hypest commented 6 years ago

FWIW, on Android we've implemented an explicit loading indicator embedded in the search input field by replacing the small "magnifying glass" icon while the operation is in progress. The magnifying glass is reinstated when the loading has finished.

folletto commented 6 years ago

Yep that's a good option too. :)

elibud commented 6 years ago

I think this one is addressed here: https://github.com/wordpress-mobile/WordPress-iOS/pull/8796 but I'll leave it to @nheagy to confirm :)

folletto commented 6 years ago

That one seems addressing when the username is changed, not removing the dark "Loader modals", or am I mistaken?

nheagy commented 6 years ago

@folletto is correct. I think this would be a nice refinement to that screen.

stale[bot] commented 5 years ago

This issue has been marked as stale because:

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority (cc @designsimply).

designsimply commented 5 years ago

Tested with WP Internal 12.0.0.20190311 on iPhone 6S iOS 12.1.4 and confirmed the dark loader modal is still in place when changing a username during signup. (47s)

elibud commented 4 years ago

@frosty maybe a good one for the unified login/signup project

frosty commented 4 years ago

@mindgraffiti Username selection currently isn't part of the US&L designs, is it?

mindgraffiti commented 4 years ago

@frosty @elibud Nope, username selection isn't part of the UL&S designs.

mindgraffiti commented 4 years ago

Findings: the username selector isn't just used by the Epilogue, it's also used in Account Settings. If we update it, it will be for both areas. I would add this one to the Big Titles project, not UL&S.

frosty commented 4 years ago

Thanks for checking, @mindgraffiti! I think this is probably different enough that it can be its own mini task :)