Closed itsmeichigo closed 1 year ago
Thank you for logging the issue @itsmeichigo 🙇
I have added an internal comment to discuss the possible solutions here pe5sF9-FU-p2#comment-1555
Pasting the content from my comment for future reference,
To fix this,
1. I can revert the changes from [this PR](https://github.com/wordpress-mobile/WordPressAuthenticator-iOS/pull/674).Â
 - For Woo, I can introduce a new configuration flag in [`WordPressAuthenticatorConfiguration`](https://github.com/wordpress-mobile/WordPressAuthenticator-iOS/blob/trunk/WordPressAuthenticator/Authenticator/WordPressAuthenticatorConfiguration.swift) and use `enter_email_address` step value only if that configuration flag is turned on.
1. We can change the looker dashboard to incorporate this `step` value change.Â
 - I am unfamiliar with looker, but we can explore editing the queries if we agree to choose this path.
I would prefer option two and make changes to the looker dashboard because,
1. `start` as the value for `step` is vague. And it becomes difficult to differentiate between screens when two screens have the same `flow` and `step` values. For example, both [`GetStartedViewController`](https://github.com/wordpress-mobile/WordPressAuthenticator-iOS/pull/674/files#diff-98ba589c5b81e1835ea5cfb41e036f69a1c99381ba302bbd2f52f9a74de6a7a6L454-L458) and [`SiteAddressViewController`](https://github.com/wordpress-mobile/WordPressAuthenticator-iOS/blob/trunk/WordPressAuthenticator/Unified%20Auth/View%20Related/Site%20Address/SiteAddressViewController.swift#L86-L90) had the same `step` and `flow` values before my changes.Â
1. If we revert the `step` value now, we will anyway have to adjust the looker dashboard to adjust for the events registered in the past.
I will work on a fix once we pick an option.
Description Previously in #674 we introduced a new step
enter_email_address
to differentiate the start of the two flows: site credential login and WP.com login and use that to select the appropriate help content for login failures in WCiOS.This has led to an issue with WPiOS Looker dashboard (ref: pe5sF9-FU-p2#comment-1542).
Solution We need a new configuration and only track
enter_email_address
when that config is enabled. Otherwise,start
should be use as before.