Track `signed_in` event during delegated site credential login - Githubissues

wordpress-mobile / WordPressAuthenticator-iOS

GNU General Public License v2.0

17 stars 11 forks source link

Track `signed_in` event during delegated site credential login #748

Closed selanthiraiyan closed 1 year ago

selanthiraiyan commented 1 year ago

Description

This PR starts tracking the signed_in tracks event when the client handles the site credential login.

Why?

When the client WooCommerce-iOS handles the site credential login, the user doesn't have to login using WPCOM credentials if the self-hosted site doesn't have Jetpack.
So, we must consider that the user has been logged in and track the signed_in event.

Internal discussion about the impact of this event on Tracks funnels - p1677669246532249/1677588582.228569-slack-C046HDZL87J

Testing steps

Please follow the testing instructions from https://github.com/woocommerce/woocommerce-ios/pull/9014 to test this PR.

[x] I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

selanthiraiyan commented 1 year ago

Thank @itsmeichigo! Closing this PR as this change isn't needed anymore. More details - https://github.com/woocommerce/woocommerce-ios/pull/9014#issuecomment-1450511106