Bump deployment target to iOS 15.0

wordpress-mobile / WordPressAuthenticator-iOS

GNU General Public License v2.0

17 stars 11 forks source link

Bump deployment target to iOS 15.0 #780

Open mokagio opened 1 year ago

mokagio commented 1 year ago

What it says in the title.

Both current known consumers of the library target iOS 15 and upwards.

This, unfortunately, introduced various deprecation warnings. Fixing them is out of scope at the moment, given the possibility that soon some of the affected classes will be removed as part of a UX refresh.

[x] I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

crazytonyli commented 1 year ago

Oh no, those warnings failed CI build.

[!] WordPressAuthenticator did not pass validation, due to 16 warnings (but you can use --allow-warnings to ignore them).

mokagio commented 1 year ago

@crazytonyli thank you for checking!

😳 ouch... 🤔 I like how our pod validation doesn't allow warnings. So, I think it might be best to bench this PR.

As per the PR description, I don't think it's worth spending time on those warnings at the moment:

Fixing them is out of scope at the moment, given the possibility that soon some of the affected classes will be removed as part of a UX refresh.

What do you think?