Add an option to disable Passkeys

wordpress-mobile / WordPressAuthenticator-iOS

GNU General Public License v2.0

17 stars 11 forks source link

Add an option to disable Passkeys #809

Closed kean closed 10 months ago

kean commented 10 months ago

This PR adds a temporary option to disable passkeys.

To test: see https://github.com/wordpress-mobile/WordPress-iOS/pull/22113.

[ ] I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

momo-ozawa commented 10 months ago

@Ecarrion - just a heads up, no changes required on the Woo side

kean commented 10 months ago

I was originally planning to merge this in trunk and release as 7.4.0, but I noticed there have been multiple changes (refactoring) made in trunk since the previous release. I would suggest erring on the side of caution and either releasing this as a patch for 7.3.0 or merging the original PR in WordPress-iOS https://github.com/wordpress-mobile/WordPress-iOS/pull/22113 with this branch as a dependency. @mokagio, I would appreciate your help in deciding the best way forward.

mokagio commented 10 months ago

I would suggest erring on the side of caution and either releasing this as a patch for 7.3.0 or merging the original PR in WordPress-iOS https://github.com/wordpress-mobile/WordPress-iOS/pull/22113 with this branch as a dependency.

Good thinking @kean. For the sake of keeping releases tidy, I'll take this over and ship it as 7.3.1. 🙇‍♂️

mokagio commented 10 months ago

Closing in favor of #812.

Next steps:

Deploy 7.3.1
Point https://github.com/wordpress-mobile/WordPress-iOS/pull/22113 to 7.3.1