wordpress-mobile / WordPressAuthenticator-iOS

GNU General Public License v2.0
17 stars 11 forks source link

Add unit tests for how the rows in the TwoFAVC are computed #810

Closed mokagio closed 10 months ago

mokagio commented 10 months ago

Builds on top #809 . While looking at that PR, I noticed that there are three essentially boolean parameters that drive the rows behavior (either actual Bool or Optional .some vs .none). That results into eight possible runtime input configurations. Too many to test manually, but easily testable via unit tests.

In truth, there's an additional boolean parameter, #available(iOS 16) but I decided to ignore that under the assumption that it's most of the user base.


mokagio commented 10 months ago

Thanks for indulging my silly typo fix!

Not at all silly! As you know, tpyos matter here. Ref pb6Nl-dHI-p2