wordpress-mobile / WordPressAuthenticator-iOS

GNU General Public License v2.0

17 stars 11 forks source link

Fixes issue where "Use Security Key" option should not be present #820

Closed Ecarrion closed 9 months ago

Ecarrion commented 9 months ago

closes #817

Why

This PR fixes an issue where the Security Key option is displayed for an account that does not have a Security Key setup.

This happened because there were some nonce state that weren't being cleared properly when logging in with a new account.

How

Clean the nonce state when the 2Factor code screen is presented.
For extra safety, improve the check before rendering the security key option.

Demo

https://github.com/wordpress-mobile/WordPressAuthenticator-iOS/assets/562080/69de42dd-437f-4149-949d-2e8668f81151

Testing Steps

You can follow the steps on this PR

https://github.com/woocommerce/woocommerce-ios/pull/11579

kean commented 9 months ago

I tested the change in WP-iOS https://github.com/wordpress-mobile/WordPress-iOS/pull/22309 and the issue was fixed.