wordpress-mobile / WordPressAuthenticator-iOS

GNU General Public License v2.0
17 stars 11 forks source link

Implement needsMultifactorCode with userId and nonceinfo delegate in StoredCredentialsAuthenticator #830

Closed staskus closed 8 months ago

staskus commented 8 months ago

Fix login being stuck in a loading state when the account has 2FA with passkeys enabled.

Fix implements needsMultifactorCode(forUserID userID: Int, andNonceInfo nonceInfo: SocialLogin2FANonceInfo) delegate which is called when nonceInfo != nil which presents 2FA login.

Context: p1706533264603049-slack-C012H19SZQ8


https://github.com/wordpress-mobile/WordPressAuthenticator-iOS/assets/4062343/9874afb2-188d-424d-b656-da03b9f6b9d2

staskus commented 8 months ago

@Ecarrion 👋 Letting you know. We've noticed on the JP app that login from the home screen doesn't work if the account has 2FA with passkey enabled.

staskus commented 8 months ago

Thank you for reviews, @guarani @Ecarrion!