wordpress-mobile / WordPressAuthenticator-iOS

GNU General Public License v2.0
17 stars 11 forks source link

Show social login options in site credentials login mode #849

Closed selanthiraiyan closed 6 months ago

selanthiraiyan commented 6 months ago

Closes #848

Description

The login screen GetStartedViewController doesn't show the social login buttons if enableSiteCredentialsLoginForSelfHostedSites is enabled in configuration.

The social buttons should be displayed if enableSocialLogin is enabled in the configuration. (Irrespective of whether enableSiteCredentialsLoginForSelfHostedSites is true/false)

This PR updates the GetStartedViewController to show the social login options.

Warnings in CI

There are warnings while validating the podspec because a method related to Gravatar image has been deprecated in https://github.com/wordpress-mobile/WordPressUI-iOS/pull/156/

I made an attempt to resolve the warnings.

For the time being, I used https://github.com/wordpress-mobile/WordPressAuthenticator-iOS/pull/850allow-warningshttps://github.com/wordpress-mobile/WordPressAuthenticator-iOS/pull/850 by Tony, which allows warnings in CI.

Internal discussion about why allow-warnings has been enabled in CI - p1712640270467459/1712574752.341039-slack-CC7L49W13

Before After
Simulator Screenshot - iPhone 13 Pro - 2024-04-08 at 14 27 34 Simulator Screenshot - iPhone 13 Pro - 2024-04-08 at 14 22 06

Testing

Please follow the steps from https://github.com/woocommerce/woocommerce-ios/pull/12429 for testing.


selanthiraiyan commented 6 months ago

Thanks for the review, @itsmeichigo! 🙇 I have addressed your comments. Please feel free to comment if you have further comments.

itsmeichigo commented 6 months ago

All good, please feel free to merge the PR.