The login screen GetStartedViewController doesn't show the social login buttons if enableSiteCredentialsLoginForSelfHostedSites is enabled in configuration.
The social buttons should be displayed if enableSocialLogin is enabled in the configuration. (Irrespective of whether enableSiteCredentialsLoginForSelfHostedSites is true/false)
This PR updates the GetStartedViewController to show the social login options.
Closes #848
Description
The login screen
GetStartedViewController
doesn't show the social login buttons ifenableSiteCredentialsLoginForSelfHostedSites
is enabled in configuration.The social buttons should be displayed if
enableSocialLogin
is enabled in the configuration. (Irrespective of whetherenableSiteCredentialsLoginForSelfHostedSites
is true/false)This PR updates the
GetStartedViewController
to show the social login options.Warnings in CI
There are warnings while validating the podspec because a method related to Gravatar image has been deprecated in https://github.com/wordpress-mobile/WordPressUI-iOS/pull/156/
I made an attempt to resolve the warnings.
For the time being, I used https://github.com/wordpress-mobile/WordPressAuthenticator-iOS/pull/850allow-warningshttps://github.com/wordpress-mobile/WordPressAuthenticator-iOS/pull/850 by Tony, which allows warnings in CI.
Internal discussion about why allow-warnings has been enabled in CI - p1712640270467459/1712574752.341039-slack-CC7L49W13
Testing
Please follow the steps from https://github.com/woocommerce/woocommerce-ios/pull/12429 for testing.
CHANGELOG.md
if necessary.