wordpress-mobile / WordPressAuthenticator-iOS

GNU General Public License v2.0
17 stars 11 forks source link

Hide site credential login button from Get Started screen after entering a WPCom site address #855

Closed itsmeichigo closed 2 months ago

itsmeichigo commented 2 months ago

Part of https://github.com/woocommerce/woocommerce-ios/issues/13622

Description On WCiOS we support site credential login for self-hosted sites with JP connection. In a previous attempt to add the site credential login option, we accidentally enabled that option for WPCom sites. This option is not functional as it's impossible to log in to WPCom sites with site credentials, so this PR fixes this by hiding that option for WPCom sites.

Testing steps Test the demo app to ensure that the credential login button is not available in the default case. Additionally, follow the steps in https://github.com/woocommerce/woocommerce-ios/pull/13623 to check the cases for WCiOS.


itsmeichigo commented 2 months ago

Thanks Hafiz for the review! I've added 2 comments to bump the library version and will release the new version after this PR is merged.