wordpress-mobile / gutenberg-mobile

Mobile version of Gutenberg - native iOS and Android
GNU General Public License v2.0
255 stars 56 forks source link

Add support for "stack on mobile" to Media & Text block settings, introduce conditional control to force media-first #2566

Open iamthomasbishop opened 4 years ago

iamthomasbishop commented 4 years ago

There are a couple of things at play here. Firstly, on the mobile editor we don't currently support the web's "stack on mobile" block setting on the Media & Text block, we simply display it (in the mobile editor) as if it were toggled on by default.

Additionally, the web recently introduced logic that forces the media to be displayed first on mobile. This is nice, because it is desirable in cases when a user has multiple media & text blocks that alternate directionally on a page but they want to display the media first on each block. However, there may be cases where the user wants to override this default behavior.

Current mobile settings

For context, here is the current block settings sheet, with and without media:

Proposal

First of all, let's add support for the "Stack on mobile" control. This will be toggled on by default, and allow the block to display "naturally" if the setting is toggled off (in other words, to not stack).

Second, let's provide another table row that is only visible when the "stack on mobile" setting is toggled to on. This row should be titled either Display media first when stacking or Display media first on mobile. It should have a Toggle control, and be toggled on by default.

Alternatively, if we don't want to introduce another toggle to allow overriding of the default stacking order, we can simply follow the web and default to media-first. I'm open to discussion on this.

Here's what that would look like, with the "Stack on mobile" switch on and off:

Note: we would always display the "Stacked on mobile", unlike the "Crop image to fill entire column" setting, which is only displayed if media is attached.

dillh commented 3 years ago

Please make this happen. As a copywriter I want to be able to control the order, not have it dictated by Wordpress. What the order needs to be on mobile depends on the nature of the text that goes with it.

mdrockwell commented 3 years ago

A request for "Stack on Mobile" option in the Media & Text block here: 3849125-zen