wordpress-mobile / gutenberg-mobile

Mobile version of Gutenberg - native iOS and Android
GNU General Public License v2.0
242 stars 55 forks source link

Improve how we detect that a post has been edited #266

Open Tug opened 5 years ago

Tug commented 5 years ago

Currently we detect if a post is modified by checking if the resulting html changed:

See: https://github.com/wordpress-mobile/gutenberg-mobile/pull/225 https://github.com/wordpress-mobile/gutenberg-mobile/pull/242 https://github.com/wordpress-mobile/gutenberg-mobile/pull/264

We'd like to improve on that logic and reuse the isEditedPostDirty selector from the gutenberg store.

However there are a few road blocks along the way:

koke commented 5 years ago

Is this the same issue than #227?

Tug commented 5 years ago

Yes, it's very close. I suggest we close #227 though as we don't use a hash anymore to check that something has changed

SergioEstevao commented 4 years ago

@Tug is this something that we still want to pursue?

hypest commented 4 years ago

We'd still want to have a performant way of checking for content dirtiness so, marking this as an enhancement and adding it to the Backlog.