search

wordpress-mobile / gutenberg-mobile

Mobile version of Gutenberg - native iOS and Android
GNU General Public License v2.0
241 stars 55 forks source link

build: Fix failure when running npm command `i18n:update` #6715

Closed fluiddot closed 5 months ago

fluiddot commented 5 months ago

This PR follows up https://github.com/wordpress-mobile/gutenberg-mobile/pull/6704 to address the issue outlined in https://github.com/wordpress-mobile/gutenberg-mobile/pull/6704#discussion_r1519649094. The solution applied is to ensure that both TARGET_PATH and USED_STRINGS_PATH variables point to an absolute path.

To test

i18n:update command:

  1. Run npm run i18n:update
  2. Observe that the command succeeds. NOTE: It's likely that localization strings files get updated.

i18n:update:test command:

  1. Run i18n:update:test.
  2. Observe that the command succeeds and that the file i18n-test/used-strings.json is created.

Build JS bundles CI job:

  1. Observe that the CI job in the commit https://github.com/wordpress-mobile/gutenberg-mobile/pull/6715/commits/6c69879adff2a06aaac3ee301994a29999ed3f35 succeeds.

PR submission checklist: