wordpress-mobile / gutenberg-mobile

Mobile version of Gutenberg - native iOS and Android
GNU General Public License v2.0
245 stars 56 forks source link

Remove `cache-builder.yml` pipeline #6733

Closed mokagio closed 6 months ago

mokagio commented 6 months ago

The changes from https://github.com/wordpress-mobile/gutenberg-mobile/pull/6719 make the need to build a Git cache unnecessary.

Testing: Ensure CI is green.

Ping @jkmassel to confirm this is the case also for the Apple Silicon CI.

My understanding is that it manages its own caching and doesn't need to read from the S3 bucket where this cache went. I say this based on looking at the pre-checkout and post-checkout hooks in the CI infra repo calling respectively hostmgr cache fetch-git-mirror and hostmgr cache publish-git-mirror. I also looked into hostmgr itself and, while I didn't go through the entire chain, my understanding there is that the Git mirror location is unrelated with what our git-s3-cache Buildkite plugin uses.

Related: https://github.com/Automattic/buildkite-ci/pull/382


PR submission checklist:

AliSoftware commented 6 months ago

My understanding is that it manages its own caching and doesn't need to read from the S3 bucket where this cache went. I say this based on looking at the pre-checkout and post-checkout hooks in the CI infra repo calling respectively hostmgr cache fetch-git-mirror and hostmgr cache publish-git-mirror. I also looked into hostmgr itself and, while I didn't go through the entire chain, my understanding there is that the Git mirror location is unrelated with what our git-s3-cache Buildkite plugin uses.

This is correct.

PS: I should really copy that explanation above in the buildkite-ci repo (under docs/) at some point, will add it to my bucket list.

AliSoftware commented 6 months ago

PS: I should really copy that explanation above in the buildkite-ci repo (under docs/) at some point, will add it to my bucket list.

Done: https://github.com/Automattic/buildkite-ci/pull/383

mokagio commented 6 months ago

Thanks for the info @AliSoftware

mokagio commented 6 months ago

I'll wait to merge this till the infra one lands

mokagio commented 6 months ago

The CI infra change has been deployed. Merging.

Thanks again @AliSoftware for the reviews 🙇‍♂️