Closed mokagio closed 6 months ago
My understanding is that it manages its own caching and doesn't need to read from the S3 bucket where this cache went. I say this based on looking at the pre-checkout and post-checkout hooks in the CI infra repo calling respectively hostmgr cache fetch-git-mirror and hostmgr cache publish-git-mirror. I also looked into hostmgr itself and, while I didn't go through the entire chain, my understanding there is that the Git mirror location is unrelated with what our git-s3-cache Buildkite plugin uses.
This is correct.
hostmgr
will take care of checking the on-premises Synology Cache first, and only hit S3 on a Cache Miss from Synology. Both the S3 bucket and the Caddy HTTP Server to check are configured in the hostmgr.json
config file.buildkite-agent.cfg
config is then set up to use the git-mirrors
(recent-ish) built-in feature of Buildkite, which basically internally does the same trick of using --reference
during git clone
as we used back in our git-s3-cache
plugin/opt/ci/git-mirrors
as a Shared Volume, then override the BUILDKITE_GIT_MIRRORS_PATH
env var to /Volumes/My Shared Files/git-mirrors
within the VM when we transfer the job from the host to the VMPS: I should really copy that explanation above in the buildkite-ci
repo (under docs/
) at some point, will add it to my bucket list.
PS: I should really copy that explanation above in the buildkite-ci repo (under docs/) at some point, will add it to my bucket list.
Thanks for the info @AliSoftware
I'll wait to merge this till the infra one lands
The CI infra change has been deployed. Merging.
Thanks again @AliSoftware for the reviews 🙇♂️
The changes from https://github.com/wordpress-mobile/gutenberg-mobile/pull/6719 make the need to build a Git cache unnecessary.
Testing: Ensure CI is green.
Ping @jkmassel to confirm this is the case also for the Apple Silicon CI.
My understanding is that it manages its own caching and doesn't need to read from the S3 bucket where this cache went. I say this based on looking at the
pre-checkout
andpost-checkout
hooks in the CI infra repo calling respectivelyhostmgr cache fetch-git-mirror
andhostmgr cache publish-git-mirror
. I also looked intohostmgr
itself and, while I didn't go through the entire chain, my understanding there is that the Git mirror location is unrelated with what ourgit-s3-cache
Buildkite plugin uses.Related: https://github.com/Automattic/buildkite-ci/pull/382
PR submission checklist: