wordpress-mobile / gutenberg-mobile

Mobile version of Gutenberg - native iOS and Android
GNU General Public License v2.0
234 stars 54 forks source link

Include Block experiments classname package #6861

Closed geriux closed 1 month ago

geriux commented 1 month ago

Related PR:

This PR adds a new step to install dependencies of the block-experiments submodule. Currently, we were relying on Gutenberg to have all needed dependencies for this submodule, but since the recent removal of the classnames package, it makes sense this submodule also installs its dependencies as we do it for Jetpack and Gutenberg.

It adds a new bash file to install the block-experiments dependencies, which will be called in the postinstall script in Gutenberg Mobile's package.json

A new item was added to Metro's block list, to not include files from the @wordpress package from its dependencies, the reason for this is to solve problems with bringing old references of older versions of the native files. This shouldn't affect anything as we are loading these packages from Gutenberg already.

To test CI checks should pass.

PR submission checklist:

geriux commented 1 month ago

Will wait for this item to be resolved before reviewing. Feel free to re-request after it's been resolved. Thanks!

Done! I decided to not unify both just in case separate configurations are preferred for each submodule 👍

geriux commented 1 month ago

Thanks @twstokes ! This PR didn't include the merge commit hash from Gutenberg so I'll create another PR to update it shortly.

twstokes commented 1 month ago

Thanks @twstokes ! This PR didn't include the merge commit hash from Gutenberg so I'll create another PR to update it shortly.

Ah! My bad on that. 😬