Closed geriux closed 1 month ago
Will wait for this item to be resolved before reviewing. Feel free to re-request after it's been resolved. Thanks!
Done! I decided to not unify both just in case separate configurations are preferred for each submodule 👍
Thanks @twstokes ! This PR didn't include the merge commit hash from Gutenberg so I'll create another PR to update it shortly.
Thanks @twstokes ! This PR didn't include the merge commit hash from Gutenberg so I'll create another PR to update it shortly.
Ah! My bad on that. 😬
Related PR:
This PR adds a new step to install dependencies of the
block-experiments
submodule. Currently, we were relying on Gutenberg to have all needed dependencies for this submodule, but since the recent removal of theclassnames
package, it makes sense this submodule also installs its dependencies as we do it for Jetpack and Gutenberg.It adds a new bash file to install the
block-experiments
dependencies, which will be called in thepostinstall
script in Gutenberg Mobile'spackage.json
A new item was added to Metro's block list, to not include files from the
@wordpress
package from its dependencies, the reason for this is to solve problems with bringing old references of older versions of thenative
files. This shouldn't affect anything as we are loading these packages from Gutenberg already.To test CI checks should pass.
PR submission checklist: