wordpress-mobile / release-toolkit-gutenberg-mobile

Automation Scripts for Releasing Gutenberg-Mobile Updates to the WordPress Mobile Apps.
Mozilla Public License 2.0
5 stars 2 forks source link

gbm CLI checklist includes clear directions #139

Closed dcalhoun closed 11 months ago

dcalhoun commented 1 year ago

Currently, when generating a release checklist with the gbm CLI, there are a few typos, missing syntax parsing, or unnecessary conditional statements. We could address these to improve clarity.

### Tasks
- [x] Update notice channel for infrastructure team (i.e. reapply #141)
- [ ] https://github.com/wordpress-mobile/release-toolkit-gutenberg-mobile/issues/147
- [x] Ensure Markdown code syntax is parsed. Replace usage of a separate Quote block with task text separated from task description by two new lines.
- [x] Given the template now adapts to the typeof release, we can remove the conditional prefix for tasks.
- [x] Repair the GitHub Release link to include the required .0 in the release, tag, and branch names.
- [x] Copy changes from https://github.com/wordpress-mobile/release-toolkit-gutenberg-mobile/pull/143
Screenshot Action
missed-interpolation Fix interpolation to display correct version number without extraneous characters.
missed-syntax-parsing Ensure Markdown code syntax is parsed. Replace usage of a separate Quote block with task text separated from task description by two new lines.
unnecessary-conditional-statement Given the template now adapts to the typeof release, we can remove the conditional prefix for tasks.
missing-zero-in-url Repair the GitHub Release link to include the required .0 in the release, tag, and branch names.
jhnstn commented 11 months ago

I believe most of the issues here were related to this

I've expanded the version verification to ensure there is always a patch value, even for .0. This seemed like the most efficient way to avoid surprises. I also don't think it's too much effort to type out the full release version.

The other issues were resolved in https://github.com/wordpress-mobile/release-toolkit-gutenberg-mobile/pull/146