search

wordpress-mobile / release-toolkit

Shared tools used in release automation
GNU General Public License v2.0
31 stars 9 forks source link

Deprecate `ios_codefreeze_prechecks` and other pre-check lanes #576

Closed mokagio closed 1 month ago

mokagio commented 1 month ago

I've started looking at the various Simplenote apps release automation with the goal to update then and eventually support releases in CI.

Internal ref p2XJRt-3Ju-p2

One thing I just noticed is the ios_codefreeze_prechecks in Simplenote iOS.

I'm not sure if we explicitly discussed this (a search for issues with "prechecks" brought no results) but I think we have decided to move on from this approach in favor of a more granular and explicit approach, where each project performs the checks it requires.

For example, WordPress iOS individually checks for the git status being clean then switches to trunk if necessary.

We could add the deprecated annotation to the lanes and then remove them whenever we'll ship a new major version.

spencertransier commented 1 month ago

Heh, I actually just started work on deprecating those today 😄 . The discussion to deprecate those got wrapped up in the versioning changes last fall. It was decided to not update the precheck actions for the versioning changes and instead add the actions and steps that used to be performed by the precheck actions into the repos themselves, for better clarity.

spencertransier commented 1 month ago

@mokagio here's the PR for the deprecations: https://github.com/wordpress-mobile/release-toolkit/pull/577