search

words / syllable

Count syllables in an English word
https://words.github.io/syllable/
MIT License
223 stars 23 forks source link

Words ending in -sed, -shed, -wed, or -xed have too many syllables. #19

Closed ibanner56 closed 6 years ago

ibanner56 commented 6 years ago

ex: "based" -> 2 "mixed" -> 2 "banished" -> 3 "shadowed" -> 3

wooorm commented 6 years ago

PRs welcome!

ibanner56 commented 6 years ago

I'll take a look if I have time over the weekend - for now I just added an extra snippet in our own code that decrements the result if it has one of those suffixes, but it's not an elegant fix.

wooorm commented 6 years ago

Thanks for raising the issue. I’d love a PR here, so if you have time to work on that I’d be super interested in it!

ibanner56 commented 6 years ago

Sure - it could be as simple as adding the suffixes to EXPRESSION_SINGLE, but I'm curious why it's just those suffixes, where words like "roughed" or "aimed" don't have the same problem.

I'd rather find the root cause than just patch the hole, but I'll dig into it when I get a chance.

ibanner56 commented 6 years ago

Oh, or even just MONOSYLLABIC_ONE - but s is already in there...

Hmmm......