words / syllable

Count syllables in an English word
https://words.github.io/syllable/
MIT License
227 stars 23 forks source link

Add some special cases to problematic.json w/ tests #24

Closed beardicus closed 6 years ago

beardicus commented 6 years ago

This adds four special cases that I had some trouble with recently:

I couldn't think of a more generalized rule for any of these that would be useful for other words as well, but would be willing to dive a little deeper if you disagree.

Thanks!

codecov-io commented 6 years ago

Codecov Report

Merging #24 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #24   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          74     74           
=====================================
  Hits           74     74

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 195c483...f7231d4. Read the comment docs.

wooorm commented 6 years ago

Thanks! Not entirely sure about the every though, but see the review above!

beardicus commented 6 years ago

If we’re wrong either way, why change it?

One reason would be if one pronunciation is much more common. Might as well be correct more often than not, if possible. I feel like two syllables is much more common for "every", but I don't have statistics to back that up. This stackexchange answer claims two syllables is more common:

The dictionaries generally describe it as having two; /ˈɛvri/ (Oxford British English), /ˈevrē/ (Oxford American English), \ˈev-rē\ (Mirriam-Webster), and that is the more common pronunciations.

I'm also noticing that while most "every____" compound words are treated by this library as if "every" is three syllables, "everyone" uses a two syllable "every".