search

words / wordnet

Node module wrapper for WordNet dictionary.
50 stars 14 forks source link

Make wordnet APIs async #3

Closed hijonathan closed 4 years ago

hijonathan commented 4 years ago

Hi there 👋 .

Admittedly I got a little carried away with this, but I was hoping to use this library and thought it could use some improvements, namely updating it to use promises.

I've included tests and (loosely) verified that it passes with the existing codebase, though the API change is breaking. I made a branch for just tests and can merge that first if you'd like. I also used tape since that seems to be what you use in other repos.

Sorry for the big PR. I tried to make as few changes as possible, but since everything seems to use callbacks it was unavoidable.

dariuszdziuk commented 4 years ago

Hi @hijonathan, glad that you found the code useful and chose to spend time on modernising it!