search

workarea-commerce / workarea

Workarea is an enterprise-grade Ruby on Rails commerce platform
https://www.workarea.com
Other
326 stars 66 forks source link

Add required option to config DSL in place of allow blank #513

Closed bencrouse closed 4 years ago

bencrouse commented 4 years ago

This removes the allow_blank option from the configuration DSL and adds the required in its place. This is done to align with developer expectations we've experienced.

bencrouse commented 4 years ago

Regarding the current field definitions, all the ones that seem required have defaults, so there wasn't a need to add required.

bencrouse commented 4 years ago

I think there's kind of 2 ways to think about what this feature is and that's leading to the confusion. One is that this is a model-like DSL to configure the Configuration::Admin instance. The other is a DSL to configure the admin UI. Maybe reconciling that will help us find clarity in the way we think about it.