search

workarea-commerce / workarea

Workarea is an enterprise-grade Ruby on Rails commerce platform
https://www.workarea.com
Other
326 stars 66 forks source link

Change admin config field DSL to define fields by ID rather than name #515

Closed mttdffy closed 3 years ago

mttdffy commented 4 years ago

WORKAREA-275

I'll have to update this with the PR for require, but its done so I opened this.

bencrouse commented 4 years ago

Looks good to me.

bencrouse commented 4 years ago

So I merged #513, no conflicts here, was there anything else you wanted to check before merging?

mttdffy commented 3 years ago

So I merged #513, no conflicts here, was there anything else you wanted to check before merging?

No. I thought for sure there would be issues. I think I assumed you'd be adding required: true to all the existing fields in 00_configuration.rb. We should do that, no?

bencrouse commented 3 years ago

Yeah, I'll update.