search

workarea-commerce / workarea

Workarea is an enterprise-grade Ruby on Rails commerce platform
https://www.workarea.com
Other
326 stars 66 forks source link

Fix Precision of Tax Rates UI #517

Closed tubbo closed 3 years ago

tubbo commented 4 years ago

The :step values of the new/edit forms and precision configuration for #number_to_percentage were not only rounding certain tax rates to an incorrect number, but were also showing a bunch of insignificant zeroes in the admin for tax rates. To resolve this, configure #number_to_percentage to have 3-decimal precision, and strip all insignificant zeroes from the display, leaving the admin with a much nicer percentage display than what was presented before.

Before:

before

After:

after

Here's another pic of all the different precision levels:

Screen Shot 2020-09-22 at 10 15 45 AM
tubbo commented 4 years ago

Card UI as well:

Screen Shot 2020-09-22 at 10 56 33 AM
bencrouse commented 3 years ago

Any reason this is a draft?