search

workarea-commerce / workarea

Workarea is an enterprise-grade Ruby on Rails commerce platform
https://www.workarea.com
Other
326 stars 66 forks source link

Bugfix/workarea 309 localized active fields #563

Closed mttdffy closed 3 years ago

mttdffy commented 3 years ago

I ran a build off a branch of this branch with localized_active_field = false here: https://github.com/workarea-commerce/workarea/actions/runs/379858423

mttdffy commented 3 years ago

Looks good, is this relevant for v3.4-stable?

I deemed it unnecessary given that this would come up from the beginning for anyone on v3.4-stable already and we haven't heard about until now. One could make the argument that upgrading 1 minor at a time you would hit this if you set it to false on v3.4, but that is something I thought of just now. Do you feel like its worth it for that reason?

mttdffy commented 3 years ago

@bencrouse after looking at v3.4. The one test that fails doesn't exists, and the complication with segments isn't an issue since it doesn't have the core segmentation in this version. Think this is good to just merge into v3.5