search

workarea-commerce / workarea

Workarea is an enterprise-grade Ruby on Rails commerce platform
https://www.workarea.com
Other
327 stars 66 forks source link

Add documentation for config.send_transactional_emails #578

Closed mttdffy closed 3 years ago

mttdffy commented 3 years ago

WORKAREA-317

mttdffy commented 3 years ago

Would you add something about how the default value prevents non-admin mail from being sent in non-production environments? That confusion is the main driver for adding this documentation.

It doesn't do that? https://github.com/workarea-commerce/workarea/blob/master/core/lib/workarea/configuration.rb#L888

bencrouse commented 3 years ago

Oh my bad, this is the wrong config value! This is the one causing the confusion: https://github.com/workarea-commerce/workarea/blob/master/core/lib/workarea/configuration.rb#L927

mttdffy commented 3 years ago

Oh my bad, this is the wrong config value! This is the one causing the confusion: https://github.com/workarea-commerce/workarea/blob/master/core/lib/workarea/configuration.rb#L927

Ah. I will add documentation for that.