workbenchapp / solana-workbench

Your one-stop shop for developing on Solana
MIT License
63 stars 7 forks source link

Transfer SOL renamed to Send SOL #219

Closed sammanadh closed 2 years ago

sammanadh commented 2 years ago
  1. Transfer SOL button renamed to Send SOL
  2. Target account input disabled in send sol popup With this change there will no way to send SOL to an account without selecting it from ProgramChange comp. Will need to add another ui element using which a user will have the freedom to paste or type any address he/she wants.
nathanleclaire commented 2 years ago

Nice!! CI wants you to take out targetPlaceholder prop in TransferSolButton

error  'targetPlaceholder' PropType is defined but prop is never used  react/no-unused-prop-types
nathanleclaire commented 2 years ago

Closes #185

sammanadh commented 2 years ago

Opps. forgot to add targetPlaceholder in props destructuring. just added.

nathanleclaire commented 2 years ago

one more ask on this one --

Since the "From" and "To" fields cannot be modify -- can you please change them from being an <input> to a <code>?

And also label them, so that "From" says something like (Your Wallet) by it, and "To" says something like (This Account)

Screen Shot 2022-07-14 at 11 26 38 AM

Thanks!

sammanadh commented 2 years ago

@nathanleclaire Have change input to code. Looks like this: Screenshot from 2022-07-15 20-35-03 Also, have done some refactoring to make prettifyPubkey "importable"

nathanleclaire commented 2 years ago

Nice!!

LGTM