search

workbenchapp / solana-workbench

Your one-stop shop for developing on Solana
MIT License
63 stars 7 forks source link

Modify default InlineKey len to 8 #224

Closed nathanleclaire closed 2 years ago

nathanleclaire commented 2 years ago

Closes https://github.com/workbenchapp/solana-workbench/issues/223

Signed-off-by: Nathan LeClaire nathan@cryptoworkbench.io

SvenDowideit commented 2 years ago

no?

can we default to not reduced - as that's the normal - we have all the space we need, and reduce it only where its needed for UX - like changes..

nathanleclaire commented 2 years ago

The reason I bring this up actually is because I want to stuff a "Tags" section in that table, ideally for 0.4.0 -- which would contain tags like Faucet, Validator Account, owner=System Program, that type of thing.

nathanleclaire commented 2 years ago

can we default to not reduced - as that's the normal

Sure

we have all the space we need

Do we? I think we tend to use monitors that are on the larger side. I want ideally WB to work pretty well out of the box on a small display, like a Macbook Air. And for the program changes in particular I think we could get more useful information in there

SvenDowideit commented 2 years ago

yes - the non-truncated pubkey fits very well in the AccountView.... the table is quite different.

but again - yes, truncate on the changes table, cos that is a space constrained thing.

eventually, it should be responsive, not hard coded...

nathanleclaire commented 2 years ago

OK yea my fault, movin too quick on the original one.

This is now closer to what I had in mind.

Seems WB opens with the left pane quite aggressively expanded, and I always have to drag the right pane over lol -- we'll have to see if we can fix that up

SvenDowideit commented 2 years ago

OMG. I just realised - we should both think more about this - I'll make a new issue!

LGTM!

nathanleclaire commented 2 years ago

thx for fast review!