workbenchapp / solana-workbench

Your one-stop shop for developing on Solana
MIT License
63 stars 7 forks source link

[WIP] Remove vite-inline-css plugin #271

Open nathanleclaire opened 2 years ago

nathanleclaire commented 2 years ago

Closes https://github.com/workbenchapp/solana-workbench/issues/269

If we can find another way to tamp down the logspam, I might be open to keeping it, but @Bluskript I'd need you to please elaborate on the advantages. We have SCSS going already, and it seems to serve a lot of the same purposes. (and @apply seems to confuse SCSS, so I'm not sure I want to write a "different type" of CSS in the JS than in our preprocessed stuff)

Generally, I'm thinking I want to remove it and keep doing things the old fashioned way cause it's simpler to understand. Appreciate the effort to try something new though.

I think this PR still doesn't look exactly right so it's a WIP. @Bluskript what am I missing?

e.g., this PR:

Screen Shot 2022-07-19 at 11 40 56 AM

main:

Screen Shot 2022-07-19 at 11 41 55 AM