workbenchapp / solana-workbench

Your one-stop shop for developing on Solana
MIT License
63 stars 7 forks source link

Confirmation dialog added while exiting a window #302

Closed sammanadh closed 2 years ago

sammanadh commented 2 years ago

fixes #287

nathanleclaire commented 2 years ago

Nice. Is this ready for review? Lint/prettier has some issues in the CI you'll want to look at cleaning up. npm run lint locally should emit them locally for your review (My VScode also shows the integrated errors and runs prettier for me)

nathanleclaire commented 2 years ago

The guilty line seems to come from @solana/web3.js so I am going to try pinning that version to a specific one and deferring the bundling compatibility to another day. https://github.com/solana-labs/solana-web3.js/blob/895de4cd66614c0cffe79061016bdb9fa3d9a6ab/src/programs/address-lookup-table/state.ts#L36

If that doesn't unbreak the build, will look at other options

nathanleclaire commented 2 years ago

OK got it, package deps didn't need to change, just the ES target. I guess the default for Vite must be es2019. I bumped it to es2021, which is what our tsconfig.json has set anyway.

nathanleclaire commented 2 years ago

LGTM