search

workbenchdev / Biblioteca

Documentation viewer for GNOME
GNU General Public License v3.0
51 stars 8 forks source link

Open bookmarks in tabs #77

Closed sonnyp closed 7 months ago

sonnyp commented 7 months ago

Been thinking about that too

we can try but it's unrelated to this

AkshayWarrier commented 7 months ago

Yeah this LGTM 👍🏻

AkshayWarrier commented 7 months ago

Oops, I just noticed a bug, the links aren't being opened in online mode (with a url bar) because the webview is connecting to the notify::uri signal after load_uri. I also realized that you can't open any http links in new tabs either (using middle-click). I'll make the fix in a new PR.

sonnyp commented 7 months ago

I noticed that too - it's also unrelated to this PR.

I recommend fixing that as part of moving to a global url bar https://github.com/workbenchdev/Biblioteca/issues/76