search

workbenchdev / Workbench

Code playground for GNOME 🛠️
https://apps.gnome.org/Workbench
GNU General Public License v3.0
697 stars 90 forks source link

Switch devel to GNOME SDK Master #980

Open vixalien opened 1 month ago

vixalien commented 1 month ago

I remember we switched to 46 instead of master in https://github.com/workbenchdev/Workbench/pull/966.

However, This means we can't use ts-for-gir (in #979), because one of the dependencies requires node 20 (and hence typescript 24.08beta).

$ yarn global add @ts-for-gir/cli@4.0.0-beta.12
yarn global v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
error glob@11.0.0: The engine "node" is incompatible with this module. Expected version "20 || >=22". Got "18.20.3"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/global for documentation about this command.

This means we should consider switching to the master. A good first point would be to list all the issues we had when we switched to master in the past.

As my internet is a bit slow, I can't really iterate on this as it requires downloading multiple runtimes and dependencies.

(cc @sonnyp @andyholmes)

andyholmes commented 1 month ago

This seems like a good idea, if Sonny approves. I usually do stable/master with my stable/devel manifests as well.

sonnyp commented 3 hours ago

:wave:

Workbench has a lot of dependencies and moving parts. From experience switching to GNOME nightly tends to break often. I try to make Workbench as easy as possible to contribute to so I'd rather stay on stable for the "main" manifest.

If needed - we could consider re.sonny.Workbench.nightly

Now that 47 is out, I'm working on upgrading which should solve your immeditate issue

Works for you?