search

workbenchdev / demos

Demos of GNOME technologies - GTK, libadwaita, CSS, portals, ...
Creative Commons Zero v1.0 Universal
11 stars 15 forks source link

Port "Banner" to Vala #115

Closed imhemish closed 8 months ago

imhemish commented 8 months ago

@Diego-Ivan @lw64 I reset the commits, made the changes, so as to not pollute the history by having a single commit. I followed the given style guide. Please look into this.

Diego-Ivan commented 8 months ago

@imhemish The indentation of your code seems to be 2 spaces. Workbench uses 4 space indentation for Vala. You can run the demo in Workbench to automatically format it.

Testing using workbench-cli is pretty useful to catch formatting errors. You can check how to use it locally in the README's testing section.

imhemish commented 8 months ago

@Diego-Ivan I tried running workbench-cli from flatpak, but it says that the binary does not exist? I verified by running a shell in flatpak container of workbench, and yes the workbench-cli binary does not exist there. Anyways i have reformatted the code with 4 spaces

sonnyp commented 8 months ago

@imhemish please use "Run" in Workbench , it will automatically format the code. It needs to be tested in Workbench anyway.