worker8 / Pixels

Pixels is an Android app that brings you the beautiful and interesting pictures from Reddit
24 stars 3 forks source link

Use epoxy for RecyclerView #23

Closed worker8 closed 5 years ago

worker8 commented 5 years ago

Overview

This PR is for changing to use Airbnb's Epoxy library for RecyclerView.

It uses annotation processing and provides diffing, which gives a cleaner code when the the requirement of the list gets more complicated, such as the Comment view, where there is 4 different view types.

Reference

The installation guide can be found here: https://github.com/airbnb/epoxy#installation

Todos

worker8-1 commented 5 years ago
12 Warnings
:warning: app/build.gradle#L48 - A newer version of androidx.recyclerview:recyclerview than 1.1.0-alpha01 is available: 1.1.0-alpha02
:warning: app/build.gradle#L50 - A newer version of androidx.paging:paging-runtime than 2.1.0-rc01 is available: 2.1.0
:warning: app/build.gradle#L64 - A newer version of androidx.lifecycle:lifecycle-extensions than 2.1.0-alpha01 is available: 2.1.0-alpha02
:warning: app/src/main/res/drawable/ic_logo_foreground.xml#L15 - Attribute endX is only used in API level 24 and higher (current min is 21)
:warning: app/src/main/res/drawable/ic_logo_foreground.xml#L16 - Attribute endY is only used in API level 24 and higher (current min is 21)
:warning: app/src/main/res/drawable/ic_logo_foreground.xml#L17 - Attribute startX is only used in API level 24 and higher (current min is 21)
:warning: app/src/main/res/drawable/ic_logo_foreground.xml#L18 - Attribute startY is only used in API level 24 and higher (current min is 21)
:warning: app/src/main/res/drawable/ic_logo_foreground.xml#L22 - Attribute offset is only used in API level 24 and higher (current min is 21)
:warning: app/src/main/res/drawable/ic_logo_foreground.xml#L25 - Attribute offset is only used in API level 24 and higher (current min is 21)
:warning: app/src/main/res/drawable/ic_outline_bug.xml#L8 - Very long vector path (852 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.
:warning: app/src/main/res/layout/comment_header.xml#L7 - Possible overdraw: Root element paints background ?pixelBackgroundColor with a theme that also paints a background (inferred theme is @style/AppTheme)
:warning: app/src/main/res/mipmap-hdpi/ic_launcher_round.png#L0 - Launcher icon used as round icon did not have a circular shape

Generated by :no_entry_sign: Danger