search

worker8 / Pixels

Pixels is an Android app that brings you the beautiful and interesting pictures from Reddit
24 stars 3 forks source link

[Chore] Minor cleanup #31

Closed kittinunf closed 5 years ago

worker8-1 commented 5 years ago
9 Warnings
:warning: app/src/main/res/drawable/ic_logo_foreground.xml#L15 - Attribute endX is only used in API level 24 and higher (current min is 21)
:warning: app/src/main/res/drawable/ic_logo_foreground.xml#L16 - Attribute endY is only used in API level 24 and higher (current min is 21)
:warning: app/src/main/res/drawable/ic_logo_foreground.xml#L17 - Attribute startX is only used in API level 24 and higher (current min is 21)
:warning: app/src/main/res/drawable/ic_logo_foreground.xml#L18 - Attribute startY is only used in API level 24 and higher (current min is 21)
:warning: app/src/main/res/drawable/ic_logo_foreground.xml#L22 - Attribute offset is only used in API level 24 and higher (current min is 21)
:warning: app/src/main/res/drawable/ic_logo_foreground.xml#L25 - Attribute offset is only used in API level 24 and higher (current min is 21)
:warning: app/src/main/res/drawable/ic_outline_bug.xml#L8 - Very long vector path (852 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.
:warning: app/src/main/res/layout/comment_header.xml#L7 - Possible overdraw: Root element paints background ?pixelBackgroundColor with a theme that also paints a background (inferred theme is @style/AppTheme)
:warning: app/src/main/res/mipmap-hdpi/ic_launcher_round.png#L0 - Launcher icon used as round icon did not have a circular shape

Generated by :no_entry_sign: Danger

kittinunf commented 5 years ago

Thanks for the review!!! I will merge as soon as I got 🍏 from CI

kittinunf commented 5 years ago

Merging this if you are okay with this! @worker8

worker8 commented 5 years ago

image

nice commit message 👍 and thanks!