The main goal of this PR is to remove the unused app_name string from the library module.
The problem happens when the library is added into a project, and app_name is not defined is the root module. In that case, gradle doesn't know which definition of app_name is more important, so it might device to use Tour Guide as app_name :(
app_name is unused anyway, so I thought I could remove it to avoid confusion.
As for ic_launcher1, I just saw it was unused so I thought it's be ok to remove it to avoid conflicts and save some space.
worker8
commented
6 years ago
The main goal of this PR is to remove the unused
app_namestring from the library module.The problem happens when the library is added into a project, and
app_nameis not defined is the root module. In that case, gradle doesn't know which definition ofapp_nameis more important, so it might device to useTour Guideasapp_name:(app_nameis unused anyway, so I thought I could remove it to avoid confusion.As for
ic_launcher1, I just saw it was unused so I thought it's be ok to remove it to avoid conflicts and save some space.note: tests run ok in my machine