search

workfloworchestrator / orchestrator-core

The workflow orchestrator core repository
Apache License 2.0
41 stars 15 forks source link

inputstep assignee cannot be None #236

Closed Mark90 closed 1 year ago

Mark90 commented 1 year ago

The assignee parameter to inputstep() can be left None, but this causes SQL errors (and the workflow staying in "Running") as the field is non-null in the database.

The parameter should have a sensible default, or otherwise raise an error if left None.

https://github.com/workfloworchestrator/orchestrator-core/blob/586efd493f693504b05b6883e7fef16c44b3db95/orchestrator/workflow.py#L254

crankynetman commented 1 year ago

I guess I didn't see this before, but we probably should close this as a duplicate of #243. Sorry for the duplicate issue 🤦‍♂️

Mark90 commented 1 year ago

I guess I didn't see this before, but we probably should close this as a duplicate of #243. Sorry for the duplicate issue 🤦‍♂️

No problem at all, thanks for addressing it :)